Open
Conversation
👷 Deploy request for orcamap pending review.Visit the deploys page to approve it
|
Member
|
Hey @stedy -- I'm not a coder, but am curious: why did you abandon typescript? |
Author
|
I could not get the repo to run on my local machine so I just started paring it down until I could get it to work. I am not really a web developer (and certainly have nothing against typescript!) but I just wanted to get a map working in a react framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR 🚀 fulfills the following requirements:
npm run start) was run locally and new changes were working correctlynpm run linter) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
I could not get the main branch to build on my local machine so I removed many of the dependencies in an attempt to get it working. After doing so, I mainly focused on the map feature so I refactored the code to use acartia.io API instead of google sheets. There is more to be done for sure but I wanted to make a branch that worked from a fresh install to encourage others to contribute.
Fixes #
What is the new behavior?
Runs using
npm start, better map visualizationDoes this introduce a breaking change?
Checklist_User's_Behalf:
Not sure, does make several major changes (such as abandoning typescript) but hopefully moves this project forward.
Other information